[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23760 [Core Tor/Tor]: Use node_get_curve25519_onion_key() in extend_info_from_node()

#23760: Use node_get_curve25519_onion_key() in extend_info_from_node()
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  (none)
     Type:  enhancement     |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  refactor, easy  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_revision


Comment:

 Hi neel, thanks for the patch!

 node_get_curve25519_onion_key() returns a const pointer, so the variable
 also has to be const. Otherwise, some compilers will complain.

 The rest of the patch looks good!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23760#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs