[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24327 [Metrics/ExoneraTor]: Sort results under technical details by timestamp and, if necessary, by fingerprint



#24327: Sort results under technical details by timestamp and, if necessary, by
fingerprint
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  defect              |         Status:  merge_ready
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Looks ok, tests and checks pass, except that checkstyle wants the
 following change in order to not complain:

 {{{
 --- a/src/main/java/org/torproject/metrics/exonerator/QueryServlet.java
 +++ b/src/main/java/org/torproject/metrics/exonerator/QueryServlet.java
 @@ -347,7 +347,8 @@ public class QueryServlet extends HttpServlet {
                  return m1.timestamp.compareTo(m2.timestamp);
                } else {
                  return m1.fingerprint.compareTo(m2.fingerprint);
 -              }});
 +              }
 +            });
 }}}

 Ready to merge w/o the checkstyle complaint.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24327#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs