[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24367 [Core Tor/Tor]: Changing pluggable transports (during start-up) in Tor Browser is broken

#24367: Changing pluggable transports (during start-up) in Tor Browser is broken
-------------------------------------------+-------------------------------
 Reporter:  gk                             |          Owner:  (none)
     Type:  defect                         |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.3.2.x-final
Component:  Core Tor/Tor                   |        Version:  Tor:
                                           |  0.3.2.1-alpha
 Severity:  Normal                         |     Resolution:
 Keywords:  regression, tor-bridge-client  |  Actual Points:
Parent ID:                                 |         Points:  0.5
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------
Changes (by teor):

 * cc: nickm, asn (added)
 * keywords:   => regression, tor-bridge-client
 * version:   => Tor: 0.3.2.1-alpha
 * status:  new => needs_revision
 * points:   => 0.5


Comment:

 The underlying issue here is that every use of
 any_bridge_descriptors_known() in tor is wrong. Instead, we want to know
 if num_bridges_usable() > 0.

 This is a bug introduced in commit 93a8ed3 in 0.3.2.1-alpha by #23347. But
 it was also a bug in commit eca2a30 in 0.2.0.3-alpha, but we've never
 encountered it before, because we always retried our bridges immediately
 (and far too often).

 My branch bug24367 at https://github.com/teor2345/tor.git passes all of
 `make test-network`, but fails some of the guard and microdesc unit tests.
 This probably means the unit tests were relying on the buggy behaviour,
 and need to be changed. I might need nickm or asn to help me fix the unit
 tests, because they wrote them.

 I think this branch fixes the issue after quitting the browser. It might
 also fix the stalled bootstrap or error, but I'm not sure. Can you re-test
 with this branch?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24367#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs