Re: [tor-bugs] #23953 [Core Tor/Tor]: Use stdatomic counters where available

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23953: Use stdatomic counters where available
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-25  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  dgoulet          |        Sponsor:
-----------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've added a commit for the inlining changes -- but I think the (void)
 won't actually stop the compiler from optimizing stuff -- it just tells it
 not to warn us about "counter" being unused.

 For the annotations, I'd rather just run the
 `scripts/maint/annotate_ifdef_directives script from time to time, and let
 that make the changes for me?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23953#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs