[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22983 [Metrics/Library]: Add a Descriptor subinterface and implementation for Tor web server logs
#22983: Add a Descriptor subinterface and implementation for Tor web server logs
-----------------------------+-----------------------------------
Reporter: iwakeh | Owner: metrics-team
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: metrics-lib 2.2.0
Component: Metrics/Library | Version:
Severity: Normal | Resolution:
Keywords: metrics-2017 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+-----------------------------------
Comment (by iwakeh):
Replying to [comment:50 karsten]:
> Agreed with all points above except one:
Fine.
>
> ...
> Does that mean we should provide a general-purpose log parser? Probably
not.
This is my main concern here.
> ... In the parser we don't have to provide getters for fields that we
don't care about, like user-agent string. But we should be prepared to
find request methods GET, HEAD, POST, or really anything else in log lines
we're given.
Maybe, the general rule here could be that the parser/validator accepts
the format in a backward compatible way, i.e., log lines that have been
valid at some point will be parsed/valid in future? This would enable
parsing of HEAD from your example above and also accommodate changes life
accepting FTP in future with the benefit of having a defined pattern of
valid log lines that is more restrictive than a general log parser.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22983#comment:51>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs