Re: [tor-bugs] #21827 [Metrics/Onionoo]: Add recommended_version to bridge details document

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21827: Add recommended_version to bridge details document
-----------------------------+------------------------------
 Reporter:  cypherpunks      |          Owner:  metrics-team
     Type:  enhancement      |         Status:  closed
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:  fixed
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:4 iwakeh]:
 > As remarked on #22488: tests and checks pass, spec changes describe the
 changes.

 Great, thanks for checking! Merged. Closing.

 > The method name `getRecommendedVersion` is quite misleading - especially
 together with `getVersion` - as it returns a boolean not a version value,
 but as the method was introduced long ago this shouldn't halt a merge.
 >
 > Maybe, the naming could be improved at some point?

 Sure, we can improve the naming anytime. I just created #24419 for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21827#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs