[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28144 [Applications/Tor Browser]: Update projects/tor-browser for Android

#28144: Update projects/tor-browser for Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201811, TBA-a2                   |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:20 gk]:
 > Replying to [comment:19 sisbell]:
 > > I'm not seeing the debug flag on the debug signed build that we
 generate. From what I can tell in line 78 of
 ./mobile/android/app/build.gradle, it is saying if MOZILLA_OFFICIAL is
 set, then it flags the build as not debuggable. This has implications such
 as reduced logging and not being able to step through debug points with
 the IDE. If we also flag as nightly build AND debug, it will overwrite the
 MOZ_OFFICIAL flag.
 > >
 > > I'm not sure if this is something we should be concerned about right
 now? Or can we just push it off for now?
 >
 > I think that's fine for now.

 I agree. Currently, for releasing, we only build TBA with
 MOZILLA_OFFICIAL=1. If someone needs a debuggable build, then they can
 build that separately (we can document how a developer should accomplish
 this). In fact, the reason we added `export MOZILLA_OFFICIAL=1` into
 .mozconfig-android (and subsequently other mozconfigs) was because when we
 first tried uploading the first TBA alpha version to Google Play, it still
 had debuggable=true, and Google Play rejected it. I believe tor-browser-
 build should output releasable bundles.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28144#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs