[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28458 [Core Tor/sbws]: Stop resolving domains locally and check same flags for the 2nd hop
#28458: Stop resolving domains locally and check same flags for the 2nd hop
---------------------------+--------------------------------
Reporter: juga | Owner: juga
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Core Tor/sbws | Version: sbws: 1.0.0
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------+--------------------------------
Comment (by teor):
Replying to [comment:15 juga]:
> Replying to [comment:14 pastly]:
> > I think there's two changes that should be made as part of this
ticket, and somehow that's exploded into a lot of little buggy revisions.
>
>
> Solution:
> When you feel like reviewing a ticket, put yourself as reviewer,
otherwise i'll assume nobody is going to review the ticket.
> I won't put any ticket to `needs_review` unless it has a reviewer.
> If it doesn't have reviewer, i might do the refactors that help me to
solve the ticket in the same branch (in different commits).
> If you'd like to continue to review this ticket, please put yourself as
reviewer. If not, no need to read more.
In Core Tor/Tor, we set a ticket as needs_review when it is ready for
review, then assign a reviewer.
You can use a different process for sbws if you like.
But if you want more reviews from people who usually work on Tor, please
use the same review process.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28458#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs