[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32339 [Core Tor/Tor]: Use a table to drive options_check_transition and warn_about_relative_paths
#32339: Use a table to drive options_check_transition and warn_about_relative_paths
------------------------------------+------------------------------------
Reporter: teor | Owner: (none)
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: network-team-roadmap-? | Actual Points: .1
Parent ID: #29211 | Points: 1
Reviewer: teor | Sponsor: Sponsor31-can
------------------------------------+------------------------------------
Changes (by nickm):
* status: needs_revision => needs_review
Comment:
One challenge with looping over logs is that we only want to look at the
filenames. We'd also want to look at filenames inside FooPort options
My eventual hope with Logs and Ports is that we can reuse the control-
command parsing code in control_cmd.c to break them into their own options
objects, and handle those with the regular configuration processing code.
Do you think that, for now, we might be able to take this patch as a
straightforward refactoring, and add additional checks in a separate
branch? For me it is a blocker for #30866, and I'd like to get that
straightened out.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32339#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs