[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc



#30552: Android - Clean up torrc
----------------------------------------------+----------------------------
 Reporter:  sysrqb                            |          Owner:  tbb-team
     Type:  defect                            |         Status:
                                              |  needs_revision
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911  |  Actual Points:
Parent ID:                                    |         Points:  0.5
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------

Comment (by sisbell):

 I made the change to accept 0 value for a port and null will assign "auto"
 as the value. Anything less than 0 will throw an IllegalArgumentException.
 This is a runtime exception so we won't start tor at all if user passes in
 negative value. I added unit tests to verify behavior.

 https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/47b53aeb243639a3ffd46916d88111d71e8ea124

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30552#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs