[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser
#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+------------------------------
Reporter: arthuredelstein | Owner: JeremyRand
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201911R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+------------------------------
Comment (by gk):
Thanks for the patches! The construction with the `ncdns-repro` repo seems
weird. I don't think this belongs into the top level of the `tor-browser-
build` repo. Rather, looking at its contents this needs to get integrated
into the projects. Or, rather, all the projects you need should get
integrated into `projects`. But maybe I am missing something here. Could
you elaborate?
FWIW: there is at least one (non-fatal) error I get during running the
build that might be related to the above as you seem to try to remove a
thing that cannot be removed:
{{{
git submodule update --init
Submodule 'ncdns-repro' (https://github.com/namecoin/ncdns-repro.git)
registered for path 'ncdns-repro'
Cloning into '/home/gk/tor-browser-build/ncdns-repro'...
Submodule path 'ncdns-repro': checked out
'1a81e71504466a518c0aa7562d393ce0e06fc22a'
make -C ncdns-repro submodule-update
make[1]: Entering directory '/home/gk/tor-browser-build/ncdns-repro'
./setup-submodule-symlinks
rm: cannot remove 'tor-browser-build': Is a directory
make[1]: Leaving directory '/home/gk/tor-browser-build/ncdns-repro'
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs