[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30867 [Circumvention/Snowflake]: Write proxy-go tests to cover existing implementation
#30867: Write proxy-go tests to cover existing implementation
-------------------------------------------------+-------------------------
Reporter: cohosh | Owner: cohosh
Type: defect | Status:
| merge_ready
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: tests, anti-censorship-roadmap- | Actual Points: 2
september |
Parent ID: #29259 | Points: 2
Reviewer: | Sponsor:
| Sponsor28
-------------------------------------------------+-------------------------
Comment (by cohosh):
Replying to [comment:7 dcf]:
> Incidentally, the new tests reveal that some functions are probably
logging at too low a level -- I normally wouldn't expect the kind of code
dealt with in unit tests to log.
> {{{
> 2019/11/09 13:53:45 invalid character 'e' in literal true (expecting
'r')
> .2019/11/09 13:53:45 Cannot deserialize SessionDescription without sdp
field.
> .2019/11/09 13:53:45 Cannot deserialize SessionDescription without type
field.
> .2019/11/09 13:53:45 Unknown SDP type
>
> ...2019/11/09 13:53:45 io.Copy inside CopyLoop generated an error: io:
read/write on closed pipe
> 2019/11/09 13:53:45 io.Copy inside CopyLoop generated an error: io:
read/write on closed pipe
> }}}
I agree, I think we should not be logging errors generated by CopyLoop
since one loop will always close the pipe and trigger an error in the
other loop. I'll make a new ticket for this since there are some errors
being logged in the broker after #29207 that are too much at the moment.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30867#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs