[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32500 [Core Tor/Tor]: consider clang -std=gnu99 in Travis for better C99 portability
#32500: consider clang -std=gnu99 in Travis for better C99 portability
-------------------------------------------------+-------------------------
Reporter: catalyst | Owner: teor
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: portability, tor-ci, 029-backport, | Actual Points: 0.3
035-backport, 040-backport, 041-backport, |
042-backport |
Parent ID: | Points: 0.1
Reviewer: catalyst | Sponsor:
| Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by teor):
* status: merge_ready => needs_review
* actualpoints: 0.2 => 0.3
Comment:
Replying to [comment:4 nickm]:
> Are we doing this with all clang builds, or only some clang builds? I
vote for "only some", since we may build differently (eg with different
autoconf results) if we do _not_ have std=gnu99 set.
catalyst had the same question in #tor-dev, so I've changed Travis to run
using a macOS `clang -std=gnu99`, and a Linux `gcc -std=gnu99`. (Just in
case gcc has extra warnings, too.)
There are fewer conflicts, so we just need to merge:
* 0.2.9: https://github.com/torproject/tor/pull/1539
* 0.3.5: https://github.com/torproject/tor/pull/1540
Test branches are here:
* https://travis-ci.org/teor2345/tor/branches
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32500#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs