[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code
#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--------------------------+------------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs | Actual Points: 0.1
Parent ID: #30022 | Points: 0.1
Reviewer: asn | Sponsor: Sponsor27-must
--------------------------+------------------------------------
Changes (by dgoulet):
* status: needs_revision => needs_review
Comment:
Replying to [comment:7 asn]:
> Hm. I think this description is not right, since we don't return `F6` if
the onion address has the wrong length (since that's how we realize it's a
v3 address). Please describe the exact cases under which we return `F6`
since it might be used as part of the error page in #30022. Also, let's
mention that it's v3 exclusive.
Pushed as fixup. Actually, all ExtendedErrors are v3 only so I added a
note to each code about it.
>
> (Also the PR did not update for some reason)
Here is the fresh PR: https://github.com/torproject/tor/pull/1555
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32546#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs