[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6569 [Stem]: Stem network status document parsing
#6569: Stem network status document parsing
--------------------+-------------------------------------------------------
Reporter: neena | Owner: neena
Type: task | Status: accepted
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: | Parent:
Points: | Actualpoints:
--------------------+-------------------------------------------------------
Changes (by neena):
* status: needs_review => accepted
Comment:
Replying to [comment:11 atagar]:
> Hi Ravi. Just finished making the changes that I wanted to for network
status document handling. Chief changes are...
>
> * addition of unit tests... lots of them :P
> * rewrite of the parsing to address some misunderstandings and make it
similar to how the other descriptors are parsed
> * addition of v2 document support
>
> Commits can be found in the document-parsing branch of my repo...
> https://gitweb.torproject.org/user/atagar/stem.git/shortlog/refs/heads
/document-parsing
I've been following them for a while, until about a week ago. It looked
good, AFAIR.
> This is... an immense change...
>
https://gitweb.torproject.org/user/atagar/stem.git/commitdiff/31eb0e1?hp=ac5be8c
>
> If you would like to review it then I'd welcome your comments. However,
it took me weeks to get through the diff when you sent it to me for
review, so I'd certainly understand if this is too big to reasonably go
through. Up to you.
I'm travelling and I won't be able to review it until middle of next week.
I think it's best if you merge it now. I will suggest modifications later
when I'm back home.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6569#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs