[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4676 [Tor]: Eliminate "family" field in tor_addr_t

#4676: Eliminate "family" field in tor_addr_t
-------------------------+--------------------------------------------------
 Reporter:  nickm        |          Owner:                  
     Type:  enhancement  |         Status:  needs_review    
 Priority:  normal       |      Milestone:  Tor: unspecified
Component:  Tor          |        Version:                  
 Keywords:  tor-relay    |         Parent:                  
   Points:               |   Actualpoints:                  
-------------------------+--------------------------------------------------
Changes (by nickm):

  * milestone:  Tor: 0.2.4.x-final => Tor: unspecified


Comment:

 FWIW, I'm currently scared of this one, since if we forget
 tor_addr_make_unspec even one time, we wind up with 0.0.0.0 instead.  It
 might make more sense instead to look for places where we allocate far too
 many tor_addr_t and we would benefit from saving the 4-8 bytes lost to the
 family field on each.

 Alternatively, we could try to find some tricky way to make sure,
 mechanically, that every tor_addr_t got initialized. But I don't know a
 good solution on that one.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4676#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs