[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9934 [Tor]: Add control command to drop guard nodes

#9934: Add control command to drop guard nodes
-----------------------------+------------------------------------------
     Reporter:  ra           |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  minor        |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-client guards controller
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+------------------------------------------

Comment (by ra):

 Replying to [comment:1 nickm]:

 > * Should there be an ability to drop a specific guard?

 Dropping all guards is sufficient for my use case and the one expressed on
 tor-dev but I can't give a general answer on that.

 Replying to [comment:1 nickm]:

 > * Right now, if you call this command with arguments, they all get
 ignored.  That can't be right.
 > * The loop is strangely structured, given that "i" is never incremented.
 Perhaps it would make more sense to do `while (smartlist_len(entryguards)
 { entryguard = smartlist_get(entryguards, 0); ... }`?
 > * Remember that in C, "void fn()" is a function that takes an
 unspecified number of arguments. If you need to write a function that
 takes no arguments, you have to say "void fn(void)".

 I will rewrite and resubmit the patch.

 > * Every function should be documented.

 I though that documenting "remove_all_entry_guards" is superfluous but I
 will add a short documentation to it.

 > * Perhaps we should explain briefly what the intended use case of this
 command is.

 To the control-spec.txt..?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9934#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs