[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #9199 [BridgeDB]: Rethink the logging of BridgeDB
#9199: Rethink the logging of BridgeDB
--------------------------+------------------------------
Reporter: asn | Owner: isis
Type: task | Status: needs_review
Priority: normal | Milestone:
Component: BridgeDB | Version:
Resolution: | Keywords: bridgedb-logging
Actual Points: | Parent ID:
Points: |
--------------------------+------------------------------
Comment (by sysrqb):
Ok, very minor edits in feature/9199-improved-logging-2-r3_sy in my repo.
You may actually want to break it apart and squash them in to their
respective commits. (please make sure they all make sense and are correct)
Other thoughts:
- All other modules begin with a capital letter, can we keep this
consistent?
- Would we gain anything from sticking _emit_with_level in a class
and then having all subclasses of FileLogObserver inherit from it?
- Same for _formatTime()?
- Do we really want the default logging at Debug?
- Can we have a :raises: comment in _setPaths?
- In the docstring for getSafeLogger(), you don't show the output of the
example use of SafeLogger
It looks really good so far, and the docs are awesome. I haven't tested it
yet, nor looked at the unit tests, nor fully grokked some of the twisted
features/workarounds. These are next on the list.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9199#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs