[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4208 [Tor Weather]: Proposed fix for Weather Bug # 2719

#4208: Proposed fix for Weather Bug # 2719
-----------------------------+--------------------------
     Reporter:  buzachaka    |      Owner:  kaner
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Weather  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:  #2719
       Points:               |
-----------------------------+--------------------------

Comment (by kaner):

 Thanks for your patch.

 I've tested your regex against the previously used regex with all current
 contact lines in the consensus. Looks good, the regex works as good as the
 old one (fishes 3431 addesses out of 3983 contact lines), and fixes the
 problem with the '.at.' obfuscation.

 However, I think maybe for the final validation (lines 570-573 in your
 patch), we should think about using the validate_email() function from
 django.core.validators instead of baking our own?

 Also, how about fixing #7035 together with this?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4208#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs