Re: [tor-bugs] #13577 [Tor]: Fix clang compilation warnings in tor, trunnel

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#13577: Fix clang compilation warnings in tor, trunnel
------------------------+------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:
    Component:  Tor     |    Version:  Tor: unspecified
   Resolution:          |   Keywords:  clang
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------
Changes (by teor):

 * status:  new => needs_review


Old description:

> My branch silence-warnings on github contains fixes for:
>
>     typos in comments
>     two line lengths
>     a repeated include file, which is now only listed once
>
> Branch: silence-warnings
> Repository: ââââââhttps://github.com/teor2345/tor.git
>
> Nick, do you want the trunnel patch submitted upstream?

New description:

 My branch silence-warnings on github contains fixes to silence clang
 warnings under --enable-expensive-hardening, including:
   + implicit truncation of 64 bit values to 32 bit;
   + const char assignment to self;
   + tautological compare; and
   + additional parentheses around equality tests. (gcc uses these to
     silence assignment, so clang warns when they're present in an
     equality test. But we need to use extra parentheses in macros to
     isolate them from other code).

 Branch: silence-warnings
 Repository: ââââââhttps://github.com/teor2345/tor.git

 Nick, do you want the trunnel patch submitted upstream?

--

Comment:

 I obviously need to check copy-paste before I hit submit.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13577#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs