[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20082 [Core Tor/Tor]: Lower initial descriptor upload delay for ephemeral services



#20082: Lower initial descriptor upload delay for ephemeral services
-------------------------------------------------+-------------------------
 Reporter:  twim                                 |          Owner:
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.???
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, research, proposal-needed?,  |  Actual Points:
  TorCoreTeam201610, 030-proposed                |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorR-can
-------------------------------------------------+-------------------------

Comment (by teor):

 Thanks, we prefer git branches ;-)

 Code review:

 Removed references to rend_service_reveal_startup_time():
 * there are references in the comments as well. grep is your friend.

 Move numbers to #define
 * looks good!

 Add REND_DIRTY_DESC_STABILIZING_PERIOD_TESTING
 * The logic here is inverted: the testing period needs to be used when
 TestingTorNetwork is 1.

 Reword warning message for users and leave a comment for developers
 * looks good!

 In future, please add a short message to the commit saying what's changed.
 (These ones look like they will squash nicely into one commit, so no need
 to fix them.)

 This also needs a changes file. See tor/changes/ for examples, or read
 doc/HACKING/CodingStandards.md

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20082#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs