[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20244 [Applications/Tor Browser]: Move privacy checkboxes to about:preferences#privacy (proposed)

#20244: Move privacy checkboxes to about:preferences#privacy (proposed)
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-usability,                       |  Actual Points:
  TorBrowserTeam201610R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 First notes:

 You did
 {{{
 -    if (!this.prefs.getBoolPref("extensions.torbutton.block_disk")) {
 +    if (!this.prefs.getBoolPref("browser.privatebrowsing.autostart")) {
 }}}
 once in `cookie-jar-selector.js`. Any reason you left the other three
 `extensions.torbutton.block_disk` occurrences?

 Nit: We don't have "Privacy and Security Settings" anymore on the
 preferences pane. I guess we can omit the comments now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20244#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs