[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20376 [Core Tor/Tor]: Do not mark circs for close again after relay_send_command_from_edge()
#20376: Do not mark circs for close again after relay_send_command_from_edge()
-----------------------------+------------------------------------
Reporter: twim | Owner: twim
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Minor | Resolution:
Keywords: review-group-11 | Actual Points:
Parent ID: | Points: 0.2
Reviewer: | Sponsor:
-----------------------------+------------------------------------
Comment (by twim):
Replying to [comment:8 dgoulet]:
> As far as I understand it, that function only does OP->OR or OR->OP
meaning it can't be a middle hop and thus if it's an origin circuit, it
must be outbound and have a cpath else we are using that function very
wrong.
Just checked your branch. Thanks, the condition now looks much better!
Comments and fixed callsites look good to me also.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20376#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs