[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20284 [Core Tor/Tor]: consensus weight case 2b3 does not follow dir-spec
#20284: consensus weight case 2b3 does not follow dir-spec
-----------------------------+------------------------------------
Reporter: pastly | Owner: pastly
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: review-group-11 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+------------------------------------
Changes (by teor):
* status: needs_review => needs_revision
Comment:
I am concerned that we are turning off the unit tests for
networkstatus_compute_bw_weights_v10 for consensus methods < 27, when we
will continue to use consensus methods < 27 in the live network for some
time to come.
I suggest that you run the unit test at least twice: once for a consensus
method < 27, and another for >= 27. You could use the arg parameter to
test_dir_networkstatus_compute_bw_weights_v10 to do this.
There is a passthrough setup method you can add to the unit test table at
the end of the file. It will let you declare two tests that run the same
function, and pass them different values for the argument.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20284#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs