Re: [tor-bugs] #23848 [Core Tor/Tor]: Replace all exit() calls with return code style

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23848: Replace all exit() calls with return code style
-------------------------------------------------+-------------------------
 Reporter:  hellais                              |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-mobile, 0.3.5-deferrable,        |  Actual Points:
  review-group-24                                |
Parent ID:  #23684                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 `09562421589c055a6cb49c802a248f727390d158` and
 `35746a9ee75608e7b2393e4519adca602bf2615f`  looks good.

 In `78cbced45cd244c8aab84e6fb8087b852769f5bc` the documentation string
 around the renamed function `tell_event_loop_to_run_external_code()` is
 still talking about finishing instead of running external code.

 `f0c3b6238168e351835fdc64b5c93b84d6528870` looks good.

 `c82cc8acb5aa43b3d96490d927dcc622f2c825e3` looks good, but maybe we should
 remove this code if we notice that it is never used during this release
 cycle?

 `9bafc3b1efd64b19695cd78fb51070ff8d3939f5`,
 `c247a2df6b7f6b5d997ef9e5ccc25eaaf3918db8`,
 `853e73e815c1be9c9e533160f803de56e7d21147`,
 `1df43aff41eb8198712af0aa14ec2d574b26682c`,
 `3c99b810a46c2aba2ea4108018e78bc8f6a19013`,
 `90daa28df403472d4a6aa7067ce6ab3264cdbe55`,
 `c4a07b261b552c39b64c8d47f1ba75f4bb4f37d6`, and
 `a62f59f000f05ac5f5a7a22387007a1b8c2ee2a4` all  looks good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23848#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs