[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based Tor Browser bundles are not built reproducibly with Stylo enabled using rustc > 1.25.0
#26475: ESR60-based Tor Browser bundles are not built reproducibly with Stylo
enabled using rustc > 1.25.0
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Immediate | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201810R, | Actual Points:
GeorgKoppen201810 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* keywords: tbb-rbm, TorBrowserTeam201810, GeorgKoppen201810 => tbb-rbm,
TorBrowserTeam201810R, GeorgKoppen201810
* status: new => needs_review
Comment:
I have a patch that sets `codegen-units` to `1` which seems the way to
disably Thin LTO. Alas, there is no direct option for disabling LTO yet in
1.26.1. Moreover, using the `--set` configure option to adjust the
`codegen-units` does not seem to work as the value gets interpreted as a
string but we need an integer. So, I resorted to good ol' `sed`.
I made some testbuilds and tested the compiler against the adapted script
from https://github.com/rust-lang/rust/issues/52044#issuecomment-402349038
and I got matching builds and the script is happy now.
`bug_26475_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
build.git/commit/?h=bug_26475_v2&id=e2da10a29f46762a8561e30c36915f8568d18c71)
has the proposed workaround.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26475#comment:48>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs