[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27800 [Core Tor/Tor]: Non-fatal assertion !(old) failed in node_add_to_ed25519_map

#27800: Non-fatal assertion !(old) failed in node_add_to_ed25519_map
----------------------------------+------------------------------------
 Reporter:  stefani               |          Owner:  catalyst
     Type:  defect                |         Status:  assigned
 Priority:  Very High             |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor          |        Version:  Tor: 0.3.4.8
 Severity:  Normal                |     Resolution:
 Keywords:  regression, 035-must  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------

Comment (by catalyst):

 Current hypothesis: someone misconfigures their relay and regenerates
 their rsa1024 key while leaving their ed25519 key unchanged.
 `nodelist_set_routerinfo()` gets a new node from `node_get_or_create()`,
 which zeroes the `ed25519_id`, so `node_remove_from_ed25519_map()` is a
 no-op.  On the other hand, `node_add_to_ed25519_map()` looks up the
 `ed25519_id` explicitly, which can then collide with an existing `node_t`.

 We probably want to make this log (at `LD_DIR`?) without indicating a bug,
 because I'm not convinced it's an internal error.  It should log at least
 both rsa1024 fingerprints and the colliding ed25519 key.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27800#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs