[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27273 [Core Tor/Tor]: ASan fails to link on Travis due to rustc and linker arguments
#27273: ASan fails to link on Travis due to rustc and linker arguments
--------------------------+------------------------------------
Reporter: alexcrichton | Owner: (none)
Type: defect | Status: needs_review
Priority: High | Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rust | Actual Points:
Parent ID: #25386 | Points:
Reviewer: teor | Sponsor:
--------------------------+------------------------------------
Comment (by nickm):
Okay -- Teor is swamped, so I'll try to do initial review. I've looked
over this branch and re-tested it... and I think it is good to merge. I
have just one question and a few TODOs before I go ahead:
The question:
* When can we switch back from "nightly" to "stable"? I don't want tor
to start depending on nightly, so if there's going to be a long interval,
we should add another build for rust stable (with no sanitizers).
The TODOs: (Alex, you don't need to do any of these unless you are super-
psyched to participate in the minutiae of our development process)
* Add a changes file (see doc/HACKING/CodingStandards.md)
* For the " Remove the `link_rust.sh.in` script" commit, add a bunch of
comments to include.am to explain exactly what the new RUSTFLAGS stuff
does and why it's there.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27273#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs