[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30901 [Core Tor/Tor]: Add control port trace logging to tor

#30901: Add control port trace logging to tor
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-ci-fail-sometimes network-team-  |  Actual Points:  1.8
  roadmap-august                                 |
Parent ID:  #29437                               |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------

Comment (by nickm):

 This design looks plausible.  A few suggestions to consider if they seem
 like a good idea to you:

  * The log_debug_control_trace() macro's name seems pretty long.
  * The log_debug_control_trace() macro sounds like it belongs in
 src/feature/control somewhere.
  * The documentation for the flags, including existing flags, should
 explain not only what the flags do, but why you would want to use them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30901#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs