[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

#31550: Fix shellcheck (and related) issues in start-tor-browser
-------------------------------------------+-------------------------------
 Reporter:  nickm                          |          Owner:  nickm
     Type:  enhancement                    |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-tbm, TorBrowserTeam201910  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by boklm):

 Patch 3 (`Stop using a heredoc in start-tor-browser`) and 5 (`Put curly
 quotes inside single quotes, so shellcheck believes them`) look good to
 me, so I merged them to master as commits
 `c5f30eb31a39a61fe300389fff1ff7adecb8b163` and
 `c14d73615ba8d9e12ae29f0168babc0ecbe55052`. I also updated the subject
 lines to include this bug number.

 Patches 2 and 4 also look good to me, but they are changing the same areas
 as patch 1, so I will merge them after patch 1.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31550#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs