[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31942 [Applications/Tor Browser]: Re-enable language pack signature checks for Linux and Windows and double-check macOS

#31942: Re-enable language pack signature checks for Linux and Windows and double-
check macOS
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.0-must-alpha,                  |  Actual Points:  0.25
  TorBrowserTeam201910R, GeorgKoppen201910       |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-9.0-must-alpha, TorBrowserTeam201910, GeorgKoppen201910 =>
     tbb-9.0-must-alpha, TorBrowserTeam201910R, GeorgKoppen201910
 * status:  new => needs_review
 * actualpoints:   => 0.25


Comment:

 Okay, here is what I did: I double-checked that we are using the
 unmodified language packs on Windows and Linux (we do) and that enabling
 the signature check does not cause any issues on those platforms (it does
 not).

 Moreover, I looked at the macOS bundles and it seems that we still need
 our bookmark issue workaround done in #21879, which is unfortunate. I
 wonder whether the reason for that is that macOS is the platform where we
 use the profile not in the bundle itself but I have not looked closer.

 `bug_31942` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_31942&id=ec33831d9bc09cb705f9d5b44296a1af69cca3b8)
 has the change for this bug for review, setting
 `extensions.langpacks.signatures.required` to `false` only on macOS.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31942#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs