[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31919 [Core Tor/Tor]: Add a check-local target that runs our coccinelle parsing problems script
#31919: Add a check-local target that runs our coccinelle parsing problems script
-----------------------------------+------------------------------------
Reporter: teor | Owner: (none)
Type: enhancement | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 042-can, extra-review | Actual Points: 0.8
Parent ID: | Points: 0.5
Reviewer: | Sponsor:
-----------------------------------+------------------------------------
Changes (by teor):
* keywords: 042-can => 042-can, extra-review
* reviewer: nickm =>
Comment:
Marking as extra-review for the git hooks commits:
* scripts/git: Add check_cocci_parse.sh to the pre-commit hook
* scripts/git: Only check modified files in existing git hook checks
* scripts/git: Make spaces consistent in pre-push.git-hook
Here's how you can check them:
Coccinelle checks for correct C syntax. Here's how you can test it:
* Modify a file to have really bad C syntax
* Run a hook or `make check-cocci`
* Files in `scripts/coccinelle/exceptions.txt` are ignored, they have
known bad syntax
* Files in `src/ext` are also ignored
pre-commit hook:
* At pre-push time, the pre-commit hook takes a list of changed files
from the pre-push hook. So you can call the pre-commit hook manually with
a list of files
* At pre-commit time, the pre-commit hook creates the changed file list
itself. So you can call it with no arguments, and a set of staged (`git
add`) files
* Install the hooks, and coccinelle, and try a commit
pre-push hook:
* Install the hooks, and coccinelle, and try a push
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31919#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs