Re: [tor-bugs] #1138 [Tor Client]: If bridge authority is unreachable, client doesn't fallback to bridge

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1138: If bridge authority is unreachable, client doesn't fallback to bridge
-------------------------+--------------------------------------------------
  Reporter:  arma        |       Owner:  mwenge            
      Type:  defect      |      Status:  needs_review      
  Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
 Component:  Tor Client  |     Version:  0.2.1.19          
Resolution:  None        |    Keywords:  easy              
    Parent:              |  
-------------------------+--------------------------------------------------

Comment(by arma):

 {{{
 +    if (conn->router_purpose == ROUTER_PURPOSE_BRIDGE)
 +      connection_dir_bridge_routerdesc_failed(conn);
      connection_dir_download_routerdesc_failed(conn);
 }}}

 This part makes me sad. It would be best to put the bridge-specific
 function inside the more general function, not to call both of them back-
 to-back.

 But then, I bet these functions just happen to be superficially named
 similar things, and are called from different enough places that the names
 are a coincidence.

 Somebody should open a "refactor directory.c" trac entry. Not for 0.2.2.x
 though.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1138#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs