[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2455 [Tor Relay]: Report IP of replying DNS-Server(s) so that Vidalia can display them in the log

#2455: Report IP of replying DNS-Server(s) so that Vidalia can display them in the
log
----------------------------------------------+-----------------------------
 Reporter:  bastik                            |          Owner:                    
     Type:  enhancement                       |         Status:  needs_review      
 Priority:  normal                            |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay                         |        Version:                    
 Keywords:  DNS-Hijacking, DNS-Provider, dns  |         Parent:                    
   Points:                                    |   Actualpoints:                    
----------------------------------------------+-----------------------------

Comment(by nickm):

 Hm.  There's some stuff about this that's going to be problematic.

 First off, it *can't* get propagated into the Libevent API: It breaks the
 API.  That is to say, every existing program that has been written to use
 the old Libevent evdns API would need to change.  That's a non-starter:
 libevent doesn't take patches like that.

 Second, it exposes a previously private type: the "struct nameserver" type
 is an implemenation detail of eventdns/evdns.c, and isn't supposed to be
 user-visible or user-modifiable.

 The second issue is much easier to solve than the first: the right info to
 pass back would just be a "struct sockaddr *", which ought to be
 sufficient to identify the nameserver uniquely.

 The first one is harder.  All I can think of there is a new set of APIs.
 The alternatives (breaking backward compatibility, adding a flag that
 makes the callback signature secretly different) seem either undoable or
 too hackish. To avoid doing the new set of APIs of this type more than
 once, it might be a good idea to design them to be more extensible and
 future-proof.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2455#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs