[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3656 [Tor Bridge]: Support spawning multiple protocols using the same managed proxy

#3656: Support spawning multiple protocols using the same managed proxy
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:  asn         
     Type:  defect      |         Status:  needs_review
 Priority:  normal      |      Milestone:              
Component:  Tor Bridge  |        Version:              
 Keywords:              |         Parent:              
   Points:              |   Actualpoints:              
------------------------+---------------------------------------------------

Comment(by nickm):

 On the first patch here:
  *
 managed_proxy_has_argv/managed_proxy_get_by_argv/add_transport_to_proxy/get_bindaddr_for_proxy:
 constify if they're not already constified
  * smartlist_clear() before smartlist_free() is redundant.
  * would a comma-separated list of transports be easier than multiple
 lines here?  I'm not sure the behavior is intuitive as it is.  Is this how
 we designed it?
  * This design has gotten complicated enough that we could probably use a
 big comment someplace explaining the relationship between proxies,
 transports, and bridges; who manages which when; how stuff gets launched
 and checked; how stuff gets stopped; etc


 In the future:
  * Please read your diffs as you make them; if they combine lots of
 cleanup stuff with new feature stuff with moving stuff around, see if you
 can do it in more diffs.
  * Please don't commit prints
  *

 General stuff applying to this entire branch series:

  * make check-spaces ; and make sure that --enable-gcc-warnings works
  * Have a look at the new functions added to .h files through this whole
 series.  The ones that are only used in the file that declares them should
 be static functions in that file.  The ones that are only used in the file
 that that declares them, plus in the  unit tests, should use the #ifdef
 FOO_PRIVATE trick
  * Try this stuff under valgrind; there are enough new things allocated in
 one place and freed in another that I'm a little unconfident that I
 actually checked everything completely.  (valgrind instructions in
 doc/HACKING are a must)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3656#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs