Re: [tor-bugs] #3630 [Tor Relay]: Reduce token bucket refill interval

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3630: Reduce token bucket refill interval
-------------------------+--------------------------------------------------
 Reporter:  Flo          |          Owner:                    
     Type:  enhancement  |         Status:  needs_review      
 Priority:  major        |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by karsten):

 Patch looks good.  I didn't compile or test anything, but I read the code.
 Here are a few comments:

  - The documentation of `connection_bucket_refill_helper` in
 `connection.c` says the burst value is measured per refill interval, but
 `connection_bucket_refill` passes the value from `options->BandwidthBurst`
 which is still per second.  Are we sure we're using the right burst value?

  - There's a copy-paste error in the calls of
 `connection_bucket_refill_helper` where one of the `"global_read_bucket"`s
 should be `"global_write_bucket"`.

  - The documentation in `or.h` says that `TokenBucketRefillInterval` is
 ignored when bufferevents are enabled.  This isn't the case anymore,
 right?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3630#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs