[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6810 [Flashproxy]: Reduce code duplication across client programs

#6810: Reduce code duplication across client programs
-----------------------------+-----------------
     Reporter:  dcf          |      Owner:  dcf
         Type:  enhancement  |     Status:  new
     Priority:  minor        |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------

Comment (by infinity0):

 https://github.com/infinity0/flashproxy/compare/src-tree...code-dedup

 This is my attempt. Some key points:

 - common code in the client moved to a library, "flashproxy-common"
 (import flashproxy.common)
 - common code in the facilitator (fac.py) moved to a library, "flashproxy-
 fac" (import flashproxy.fac)
 - relevant unit tests moved away from client/facilitator into library
 tests.

 flashproxy-fac stays with the main facilitator package and is installed
 together with it. But since flashproxy-common is used by the facilitator
 *and* client, it's currently in its own subdirectory. HOWEVER, "make dist"
 (at the top-level) still builds a self-contained source package which
 includes the flashproxy-common code, which I guess is what you intended.
 "make dist-exe" should work similarly, but I haven't tested it yet.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6810#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs