[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13045 [BridgeDB]: Leekspin descriptor signatures cannot be verified by Stem

#13045: Leekspin descriptor signatures cannot be verified by Stem
--------------------------+----------------------------------------
     Reporter:  isis      |      Owner:  isis
         Type:  defect    |     Status:  accepted
     Priority:  major     |  Milestone:
    Component:  BridgeDB  |    Version:
   Resolution:            |   Keywords:  leekspin, bridgedb-parsers
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+----------------------------------------

Comment (by isis):

 Replying to [comment:2 atagar]:
 > Stem vends a test_tools module that presently vends functions for easily
 doing pyflakes and pep8 as part of your tests...
 >
 > https://stem.torproject.org/api/util/test_tools.html
 >
 > For example...
 >
 > https://gitweb.torproject.org/arm.git/blob/HEAD:/run_tests.py
 >

 Oooooo. Those are super useful.

 BridgeDB's code still has some of the old stuff in it (#12505) which is
 PEP8/stylistically horrifying. Also a lot of it is just plain horrifying
 in every way. Until those are fixed up, making an automated test with
 pylint and/or pep8 would just fail, which I fear would cause confusion for
 new contributors. But it's on my TODO list, once the cleanup is done, to
 add something of the sort in order to enforce consistency.

 > I'd be ok with expanding this module to have the mocking.py functions
 for generating valid descriptor content if it would be helpful (or
 something more like what Leekspin does if that's better).

 I think Leekspin would only need
 `stem.test.mocking.sign_descriptor_content()`.

 > I've been meaning to look at Leekspin at some point to see if its
 functionality belongs in Stem but haven't had the time.

 Currently, Leekspin ''only'' generates unsanitised bridge descriptors.
 It's also on my TODO list to make it support relay descriptors. It might
 be useful if you want to test Stem's parsing of unsanitised descriptors,
 but obviously not until bugs like this one are fixed. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13045#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs