[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #12535 [Pluggable transport]: goptlib should expose a SOCKS5 server instead of SOCKS4a.
#12535: goptlib should expose a SOCKS5 server instead of SOCKS4a.
-------------------------------------+----------------------------
Reporter: yawning | Owner: yawning
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Pluggable transport | Version:
Resolution: | Keywords: goptlib, socks
Actual Points: | Parent ID: #12130
Points: |
-------------------------------------+----------------------------
Changes (by yawning):
* status: needs_revision => needs_review
Comment:
I decoupled the concurrency changes from the SOCKS5 code and started using
github to stage goptlib stuff.
https://github.com/Yawning/goptlib/compare/bug12535
Sorry for the changes around the function formerly know as
`readSocks4aConnect` looking a bit tangled in the compare output, SOCKS5
processing is a bit more involved so there's more code (and the handshake
process got split into multiple functions to reflect what SOCKS5 needs to
do), and it confuses diff.
The tests were updated to account for no longer being able to send back
responses with non-zero address/port (and my tests pass), and obfs4proxy
works with my branch.
On a side note: I may be able to simplify the concurrency stuff a bit
after thinking about it but if I ever decide to poke at that again, I'll
file a separate ticket for it.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12535#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs