[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13081 [Tor]: Fix build with Visual Studio in Windows

#13081: Fix build with Visual Studio in Windows
-------------------------------+--------------------------------
     Reporter:  NewEraCracker  |      Owner:
         Type:  defect         |     Status:  needs_revision
     Priority:  normal         |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor            |    Version:
   Resolution:                 |   Keywords:  tor-relay msvc
Actual Points:                 |  Parent ID:
       Points:                 |
-------------------------------+--------------------------------
Changes (by nickm):

 * status:  new => needs_revision
 * keywords:  tor-relay 025-backport => tor-relay msvc


Comment:

 I've applied the first one as obviously correct, and added the
 instructions as msvc-only, but the tests one isn't right.  TOR_UNIT_TESTS
 should only be defined when doing a unit tests build: it interferes with
 hardening the application.  If you can, maybe make a cleaned-up patch
 series that fixes one thing at a time, based on current maint-0.2.5 or
 master?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13081#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs