[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13089 [Onionoo]: use an embedded web server/servlet engine for Onionoo

#13089: use an embedded web server/servlet engine for Onionoo
-----------------------------+----------------------------
     Reporter:  iwakeh       |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  minor        |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------
Changes (by karsten):

 * status:  new => needs_revision


Comment:

 Neat!  Thanks for writing and submitting this patch!

 I made some tweaks in my
 [https://gitweb.torproject.org/user/karsten/onionoo.git/shortlog/refs/heads/task-13089
 task-13089 branch] that are supposed to be squashed with your commit.

 Here are some more comments for things I didn't fix/change yet:
  - Your first command line for the backend above should be `java -Xmx4096M
 -jar dist/onionoo-1.1.1.jar`.
  - I didn't manage to start the server with your second command line.
 Logs contain this line: "Web application not found onionoo-1.1.1.war".
 Hmm.  Maybe we're not supposed to create a .war for the front-end, but
 also a .jar?!...
  - Do you mind updating `vagrant/bootstrap.sh` by removing Tomcat
 specifics and installing `libjetty8-java`?  Anything else that needs
 changing?
  - Would you also want to update `INSTALL` by replacing the last section
 with new instructions?
  - It seems that the `run` Ant target is not required anymore, and
 `bin/update.sh` needs updating, too.
  - Are really all `jetty8-*.jar` files required?  Did you try taking out
 some of them?
  - I wonder if copying `logback.xml` can be avoided in `build.xml`.  Or if
 possible, is it possible to avoid copying it to directories which
 otherwise contain files under version control (`etc/`)?
  - Can you explain why you switched from `<lib>` to `<zipgroupfileset>`
 and from `<classes>` to `<fileset>`?  I assume this is related to all-in-
 one jars?
  - Should we exclude test classes from generated .jar and .war files?  I
 think I found test classes in both of them.
  - Should both back-end and front-end really log to the same files, or
 should we separate those?

 Thanks, again!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13089#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs