[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16909 [Tor Browser]: Adapt Tor Browser bundling to new HTTPS-Everywhere ID beginning with 5.1.0



#16909: Adapt Tor Browser bundling to new HTTPS-Everywhere ID beginning with 5.1.0
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  gk
         Type:           |     Status:  reopened
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-gitian, TorBrowserTeam201509R,
  Browser                |  GeorgKoppen201509
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Replying to [comment:21 jsha]:
 > Got it! Yes, we can definitely change this, the question is to what.
 From your comment, it sounds like maybe `fetch-inputs.sh` runs on a non-
 Lucid host that has a git with the `-f` flag?

 Yes, exactly.

 > I think we can probably omit the `-f` flag. I'm trying to remember why I
 needed it. In theory everything that happens inside that portion of
 `makexpi.sh` (the part that builds a specific version from a tag) happens
 in a clean checkout, and `-f` shouldn't be necessary. I'll experiment with
 it a bit. Am very open to suggestions or patches!

 Omitting `-f` would be ideal for us. If that's not possible I have to
 think a bit more about good options. Probably I'd resort to patching `-f`
 out immediately before building with some sed command in our build script.
 Ugly, but should suffice as a workaround.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16909#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs