[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20004 [Core Tor/Tor]: prop224: Add a trunnel subdirectory specifically for HS

#20004: prop224: Add a trunnel subdirectory specifically for HS
---------------------------------------------+-----------------------------
 Reporter:  dgoulet                          |          Owner:  dgoulet
     Type:  enhancement                      |         Status:
                                             |  needs_revision
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.2.9.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  tor-hs, prop224, review-group-8  |  Actual Points:  0.5
Parent ID:  #17241                           |         Points:  1
 Reviewer:  asn                              |        Sponsor:  SponsorR-
                                             |  must
---------------------------------------------+-----------------------------

Comment (by asn):

 Also, in `cell_introduce1.trunnel`:

 - I don't see anywhere the `CLIENT_PK` or `MAC` fields of the `INTRODUCE1`
 cell as specified in section `[NTOR-WITH-EXTRA-DATA]`. Also, if we have a
 MAC we also need the appropriate `ptr`s.

 - `s/Link specificer/Link specifier/`

 - Also can we replace the magic number of `rend_cookie[20]` with some sort
 of name? The actual code is using `REND_COOKIE_LEN`, but I guess we can't
 reuse that. No worries if there is no good solution here, just leave it as
 is.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20004#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs