[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17178 [Core Tor/Tor]: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous
#17178: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: enhancement | Status:
| merge_ready
Priority: High | Milestone: Tor:
| 0.2.9.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rsos, tor-hs, TorCoreTeam201609, | Actual Points: 14
review-group-5, review-group-8 |
Parent ID: | Points: 6.5
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):
* status: needs_review => merge_ready
Comment:
LGTM. I actually prefer to do the squashing myself when I can, since that
lets me make sure I understand the code, and it makes it a little easier
to make sure that What I Reviewed Is What I Merged.
I made a squashed `feature17178-v7-squashed-v2`, and used `git diff
feature-17178-v7 feature-17178-v7-squashed-v2` to make sure that it was
exactly the same as your branch.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17178#comment:90>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs