[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19317 [Metrics/CollecTor]: Sanitize TCP ports in bridge descriptors
#19317: Sanitize TCP ports in bridge descriptors
-------------------------------+---------------------------------
Reporter: karsten | Owner:
Type: enhancement | Status: needs_review
Priority: High | Milestone: CollecTor 1.2.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Comment (by iwakeh):
The notational changes (talked about in comment:6 and comment:7) should be
added to the suggestions of comment:8, which should be implemented after
the tests. (I'll add a note to ticket #19755.)
The changes in the two commits look fine.
I'm wondering if there should be a more prominent warning that bridge-
descriptors archive downloads will be different now? In a way the file
structure for 'archive' is a 'protocol', which should be defined more
clearly (eventually).
I randomly looked at the archives using command line tools; the probes
were fine, tars containing only descriptors published in the given month,
ports being in the above defined range.
So, I think this is fine to be used. As we have only one instance working
with bridge-descriptors, I agree this can be done without a release.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19317#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs