[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27403 [Applications/Tor Browser]: The onboarding bubble does not show up in the release candidate for Tor Browser

#27403: The onboarding bubble does not show up in the release candidate for Tor
Browser
--------------------------------------+------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Immediate                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201808R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by arthuredelstein):

 * keywords:   => TorBrowserTeam201808R
 * status:  new => needs_review


Comment:

 Here's my fix, also not fully tested. It worked on one machine at least.

 https://github.com/arthuredelstein/tor-browser/commit/27403

 I found that  `this._window.document.body.getBoundingClientRect().width;`
 is returning zero early on, but `this._window.innerWidth` returns the
 correct width of the window.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27403#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs