[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27403 [Applications/Tor Browser]: The onboarding bubble does not show up in the release candidate for Tor Browser
#27403: The onboarding bubble does not show up in the release candidate for Tor
Browser
--------------------------------------+------------------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status: needs_review
Priority: Immediate | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201808R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+------------------------------
Comment (by gk):
Replying to [comment:8 mcs]:
> Arthur's idea of checking against innerWindow is a good one.
>
> Here is a patch that fixes both problems for me on macOS:
> https://gitweb.torproject.org/user/brade/tor-
browser.git/commit/?h=bug27403-01&id=6eff180c3fa1d750828e355726e12d4fbec228bb
>
> I now have to disappear for the rest of today and won't have time to
make Linux and Windows builds. Please test!
Works for me on my Linux machine, nice! I am a bit confused about your
patch and your comment:6. In the patch you are using `final-up-startup`
but in the comment you said it did not work for you. What's up with that?
I checked that `profile-after-change` works (as well) which might be a
suitable fallback.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27403#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs