[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27403 [Applications/Tor Browser]: The onboarding bubble does not show up in the release candidate for Tor Browser

#27403: The onboarding bubble does not show up in the release candidate for Tor
Browser
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  closed
 Priority:  Immediate                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:  fixed
 Keywords:  TorBrowserTeam201808R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:10 mcs]:
 > Replying to [comment:9 gk]:
 > > Works for me on my Linux machine, nice! I am a bit confused about your
 patch and your comment:6. In the patch you are using `final-up-startup`
 but in the comment you said it did not work for you. What's up with that?
 >
 > I forgot that I had mentioned that in comment:6. Sorry! I think I forgot
 to copy my newly built browser into my test area before I did that test
 earlier. I caught myself making that mistake later, so I probably did
 earlier too.

 Makes sense and no worries. Thanks for your and Arthur's help. I picked up
 your patch from `bug27403-01` as it is the simplest one we found for
 fixing both issues (commit cd00a313475584c0a4b94eaea5171428b993ce5b). I
 added a small fixup to it for displaying the onboarding bubble on smaller
 displays even with width < 960px available which Arthur suggested (commit
 839cc4bd054821fe7e4c093f0a05986b83491985). Before that I mistakenly pushed
 an older proposed bugfix by Arthur
 (8b50d3f2f1bb5ce04ebf3a91ff701059fedb2da2) which I reverted with commit
 c79bb726065ce296d567a6c9ac58b37b7d750318. All this happened on `tor-
 browser-60.2.0esr-8.0-1`.

 I think we are done here now. \o/

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27403#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs