[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27315 [Core Tor/Tor]: Sandbox regression in 0.3.4.7-rc

#27315: Sandbox regression in 0.3.4.7-rc
--------------------------+------------------------------------
 Reporter:  toralf        |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.4.7-rc
 Severity:  Normal        |     Resolution:
 Keywords:  regression?   |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  ahf           |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 I have some questions here:

 - Should we really add both rules where `AT_FDCWD` is casted and where it
 isn't?

 Additionally, the following needs to change before we can accept it:

 - We need a changes file explaining the issue.
 - I think the commit message needs to contain some more information about
 what the issue is here since it's quite subtle for someone just reading
 the commit on its own.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27315#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs