Re: [tor-bugs] #27629 [Core Tor/Tor]: add len argument to consensus parsing functions

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#27629: add len argument to consensus parsing functions
--------------------------+------------------------------------
 Reporter:  cyberpunks    |          Owner:  (none)
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #27244        |         Points:
 Reviewer:                |        Sponsor:  Sponsor8
--------------------------+------------------------------------
Changes (by teor):

 * type:  defect => enhancement


Comment:

 Replying to [comment:4 cyberpunks]:
 > Replying to [comment:2 teor]:
 > > Or is this change just refactoring?
 > > For refactoring, the changes file should have the heading:
 > > Code simplification and refactoring
 > >
 https://github.com/torproject/tor/blob/master/scripts/maint/lintChanges.py#L22
 >
 > Yeah, that was just simplifying, no behavior change replacing strncmp
 with strcmpstart. #27630.
 >
 > So two changes files, both labeled as Code simplification and
 refactoring?

 "use strcmpstart() in rend_parse_v2_service_descriptor" is definitely
 "Code simplification and refactoring".

 The rest of the branch makes Tor use less RAM, so it can be: "Minor
 feature (RAM usage)".

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27629#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs